Long functions

Code longer than it needs to be: one of the ways AI coding agents bloat software, from lessloc's pattern catalog. lessloc catches it as long-function.

What makes long functions a bad practice?

The standards that call it a bad practice: Fowler: Long Function; Sonar S138; CWE-1121.

What does lessloc do about long functions?

lessloc catches it as long-function.

• long-function (tier 2): A function over 100 code lines, 20 or more of them written by the change.

Related patterns

The other patterns in Code longer than it needs to be:

• Brute-force idioms: lessloc catches it as simpler, built in for Python, JS/TS, Go, Rust, Java and C#. ruff (in every hook) and clippy (in ci) go deeper.
• Hand-built counters and flag loops: lessloc catches it as simpler.
• A catch that only rethrows: lessloc catches it as simpler.
• A promise wrapped in new Promise: lessloc catches it as simpler.
• Annotating types the compiler infers: lessloc catches it as simpler.
• A React Effect that only sets state from other values: lessloc catches it as simpler.
• Functions with many parameters (8 or more): lessloc catches it as long-params.
• Deep nesting: lessloc catches it as deep-nesting.
• If-chains on literal values: lessloc catches it as if-chain.
• A file that keeps growing: lessloc catches it as swollen-file.
• Reformatting lines the task did not change: lessloc gives every session a rule against it and catches it as churn.
• Net growth past a budget: lessloc catches it as net-growth.
• Golfed code: lessloc catches it as clever and dense-lines.